Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore logging credentials #79

Conversation

GowthamShanmugam
Copy link
Contributor

@GowthamShanmugam GowthamShanmugam commented Feb 25, 2022

Fixes: #76

Signed-off-by: Gowtham Shanmugasundaram gshanmug@redhat.com

Copy link
Contributor

@umangachapagain umangachapagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add secret namespace also.

@@ -358,7 +358,7 @@ func processDeletedSecrets(ctx context.Context, rc client.Client, req types.Name
}
}

logger.V(2).Info("List of secrets with requested name", "secret-name", req.Name, "secretlist", sameNamedDestinationSecrets, "#secrets", len(sameNamedDestinationSecrets))
logger.V(2).Info("List of secrets with requested name", "secret-name", req.Name, "#secrets", len(sameNamedDestinationSecrets))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
logger.V(2).Info("List of secrets with requested name", "secret-name", req.Name, "#secrets", len(sameNamedDestinationSecrets))
logger.V(2).Info("List of secrets with requested name", "secret-name", req.Name, "secret length", len(sameNamedDestinationSecrets))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

Comment on lines 125 to 126
logger.Info("Updating the destination secret",
"current-data", currentDest.Data,
"expected-data", expectedDest.Data)
"secret", currentDest.Name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put this in single line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

Copy link
Member

@vbnrh vbnrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can we log the secret namespace as well

return err
}
logger.V(2).Info("Listing all the Peers connected to the Source", "SourceSecret", sourceSecret, "#connected-peers", len(uniqueConnectedPeers))
logger.V(2).Info("Listing all the Peers connected to the Source", "SourceSecret", sourceSecret.Name, "#connected-peers", len(uniqueConnectedPeers))

// anyErr will have the last found error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 58 in the file. We are logging the peerref instead of the secret name.
Please change that

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2022

@vbnrh: changing LGTM is restricted to collaborators

In response to this:

Looks good. Can we log the secret namespace as well

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@GowthamShanmugam GowthamShanmugam force-pushed the fix_security_issue branch 3 times, most recently from 3ae0d17 to 46e04db Compare February 28, 2022 21:00
Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>
@vbnrh
Copy link
Member

vbnrh commented Mar 1, 2022

/approve

@openshift-ci openshift-ci bot added the lgtm label Mar 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GowthamShanmugam, umangachapagain, vbnrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 1, 2022
@umangachapagain
Copy link
Contributor

/cherry-pick release-4.10

@openshift-cherrypick-robot

@umangachapagain: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 41048d7 into red-hat-storage:main Mar 1, 2022
@openshift-cherrypick-robot

@umangachapagain: new pull request created: #80

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud credentials in Logs
5 participants